feat(sdk): Upgrade @sentry SDKs to v8.43.0

[aliu39]

Planning to instrument the new browser featureFlagsIntegration to track internal flag evaluations. We need the latest release for this (https://github.com/getsentry/sentry-javascript/releases/tag/8.43.0).

@sentry/types was deprecated so I've changed imports to use @sentry/core

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
8352	1	8351	0

View the top 1 failed tests by shortest run time

WidgetBuilderSortBySelector renders and functions correctly

Stack Traces | 0.272s run time

Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: ObjectContaining {"pathname": ".../org-slug/dashboard/1/", "query": ObjectContaining {"sort": ["-count"]}}
Received: {"pathname": ".../org-slug/dashboard/1/", "query": {"displayType": "line", "fields": ["transaction.duration", "count()", "id"], "sort": ["-count()"]}}

Number of calls: 1
    at Object.<anonymous> (.../widgetBuilder/components/sortBySelector.spec.tsx:111:26)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[JoshFerge]

why did import order change?

[billyvg]

Looks like you need to fix the import in featureObserver

[aliu39]

why did import order change?

From my pre-commit, maybe cause it's sorted by module name?

[billyvg]

why did import order change?

From my pre-commit, maybe cause it's sorted by module name?

Yeah we had to change imports from @sentry/types to @sentry/core so it resorted. In the future I would split up package upgrades from refactors (unless it's a breaking change, though we should have a more graceful upgrade process in that case).

[billyvg]

Should it not be

Suggested change

	import type {FeatureFlagContext} from '@sentry/core/build/types/types-hoist/context';
	import type {FeatureFlagContext} from '@sentry/core';

[aliu39]

I get an error importing directly, this is from vscode autocomplete. Looks like it's not exported in index

[billyvg]

Let's make sure this gets exported and updated, we shouldn't rely on importing from this

[billyvg]

Let's make sure this gets exported and updated, we shouldn't rely on importing from this