ref(feedback): release replay and feedback group types #79790
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79790 +/- ##
==========================================
- Coverage 78.44% 78.44% -0.01%
==========================================
Files 7141 7148 +7
Lines 315965 315927 -38
Branches 43541 43517 -24
==========================================
- Hits 247860 247820 -40
+ Misses 61766 61764 -2
- Partials 6339 6343 +4 |
|
@JoshFerge @wedamija do you have ideas how this change could break tests in |
|
does it fail locally? @aliu39 ? what about on master? |
@JoshFerge it fails locally on this branch, but not on master |
it seems like it could be related. can update your branch w/ master to double check. |
|
Yeah seems like it. I recently merged master, twice.
|
|
Nvm, ignore the error traceback, seems they're all handled and appear on master too |
…sed group types will create environments
| @@ -1291,7 +1291,7 @@ def create_mock_user_feedback(project, has_attachment=True): | |||
| "event_id": str(uuid.uuid4()).replace("-", ""), | |||
| "timestamp": time.time(), | |||
| "received": "2024-4-27T22:23:29.574000+00:00", | |||
| "environment": "prod", | |||
There was a problem hiding this comment.
Got it! Seems like making an occurrence for a released group type will auto-create the environment if it doesn't exist. Not sure what it was doing before, since "prod" doesn't exist
These products/features have been GA'd for a while, this saves us and SH users from having to worry about the issue platform generated FFs.
This lets us remove -ingest, -post-process-group, -visible flags
merge monday