Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releases): Split release commit from shared component #78538

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 2, 2024

It's weird we share a commit component between issue details and releases since they're totally different use cases. (suspect commits)

Uses some of the styles from the streamlined version

before (without streamline flag)
image

before (with streamline flag) this is the weird part
image

after
image

It's weird we share a commit component between issue details and releases since they're totally different use cases.

Uses some of the styles from the streamlined version
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 2, 2024
@scttcper scttcper marked this pull request as ready for review October 11, 2024 22:29
@scttcper scttcper requested a review from a team as a code owner October 11, 2024 22:29
@scttcper scttcper requested a review from a team October 11, 2024 22:30
@scttcper scttcper merged commit 20de7d4 into master Oct 15, 2024
44 checks passed
@scttcper scttcper deleted the scttcper/release-commits branch October 15, 2024 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants