Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue-details): Prevent event error section from showing up if no errors #76235

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

roggenkemper
Copy link
Member

this pr fixes a bug where the event error section was showing up when there were no event errors

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 14, 2024
@roggenkemper roggenkemper marked this pull request as ready for review August 14, 2024 22:48
@roggenkemper roggenkemper requested a review from a team August 14, 2024 22:48
Copy link

codecov bot commented Aug 14, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7656 1 7655 0
View the top 1 failed tests by shortest run time
TransactionsList Basic renders basic UI components�TransactionsList Basic renders basic UI components
Stack Traces | 0.248s run time
TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "Previous"

Here are the accessible roles:

button:

Name "Filter Transactions":
...

Name "Open in Discover":
...

--------------------------------------------------
presentation:

Name "":
...

Name "":
...

--------------------------------------------------
separator:

Name "":
...

--------------------------------------------------
listbox:

Name "Filter Transactions":
...

--------------------------------------------------
paragraph:

Name "":
...

--------------------------------------------------

Ignored nodes: comments, script, style
...
at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
at Object.<anonymous> (.../components/discover/transactionsList.spec.tsx:217:42)
at runNextTicks (node:internal/process/task_queues:60:5)
at processTimers (node:internal/timers:511:9)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@roggenkemper roggenkemper merged commit ec6d1bf into master Aug 15, 2024
41 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/eventprocessingsectionbug branch August 15, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants