Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(uptime): Bump ACTIVE_FAILURE_THRESHOLD to 3 #76218

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

wedamija
Copy link
Member

Since we're moving to 60 second intervals, we want a slightly higher failure threshold

@wedamija wedamija requested a review from a team August 14, 2024 21:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
21646 2 21644 202
View the top 2 failed tests by shortest run time
tests.sentry.uptime.consumers.test_results_consumers.ProcessResultTest�test_resolve
Stack Traces | 2.62s run time
#x1B[1m#x1B[.../uptime/consumers/test_results_consumers.py#x1B[0m:276: in test_resolve
group = Group.objects.get(grouphash__hash=hashed_fingerprint)
#x1B[1m#x1B[31m.venv/lib/python3.11.../db/models/manager.py#x1B[0m:87: in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.11.../db/models/query.py#x1B[0m:649: in get
raise self.model.DoesNotExist(
#x1B[1m#x1B[31mE sentry.models.group.Group.DoesNotExist: Group matching query does not exist.#x1B[0m
tests.sentry.uptime.consumers.test_results_consumers.ProcessResultTest�test
Stack Traces | 2.91s run time
#x1B[1m#x1B[.../uptime/consumers/test_results_consumers.py#x1B[0m:118: in test
group = Group.objects.get(grouphash__hash=hashed_fingerprint)
#x1B[1m#x1B[31m.venv/lib/python3.11.../db/models/manager.py#x1B[0m:87: in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.11.../db/models/query.py#x1B[0m:649: in get
raise self.model.DoesNotExist(
#x1B[1m#x1B[31mE sentry.models.group.Group.DoesNotExist: Group matching query does not exist.#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Since we're moving to 60 second intervals, we want a slightly higher failure threshold
@wedamija wedamija force-pushed the danf/uptime-failure-threshold-increase branch from 4aadea1 to cfa6508 Compare August 14, 2024 23:39
@wedamija wedamija merged commit 934945f into master Aug 15, 2024
48 checks passed
@wedamija wedamija deleted the danf/uptime-failure-threshold-increase branch August 15, 2024 00:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants