style(toolbar): adjust alert indicator css #76189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
commented
Aug 14, 2024
There was a problem hiding this comment.
this file was renamed to alertBadge.tsx
aliu39
approved these changes
Aug 15, 2024
| right: -6px; | ||
| top: -6px; | ||
| width: 1rem; | ||
| right: 2px; |
There was a problem hiding this comment.
Css learning question: Is right and top used to position it relative to the panel icon? How does position:absolute work here?
There was a problem hiding this comment.
Is right and top used to position it relative to the panel icon?
yes!
How does position:absolute work here?
it works so that our top and left are relative to the icon itself, since we want the dot on top of the icon.
absolute:
relative w same top & left:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
after:
