Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(features) Use dataclasses for flagpole instead of pydantic #75859

Merged
merged 9 commits into from
Aug 15, 2024
Merged

feat(features) Use dataclasses for flagpole instead of pydantic #75859

merged 9 commits into from
Aug 15, 2024

Commits on Aug 8, 2024

  1. Hackity hack

    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    efbdf08 View commit details
    Browse the repository at this point in the history

  2. Get tests passing with dataclass based logic 

    Early timing measurements are looking promising.
    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    67d43da View commit details
    Browse the repository at this point in the history

  3. Add flagpole schema 

    This schema was generated with pydantic and will be used in CI to
validate that schema and dataclasses are kept compatible, and could
be part of a validation flow for flagpole.
    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3b44321 View commit details
    Browse the repository at this point in the history

  4. Add schema and validate() to Feature

    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bbf5dca View commit details
    Browse the repository at this point in the history

  5. Fix failing tests and createflag command

    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    45431c9 View commit details
    Browse the repository at this point in the history

  6. Fix mistake

    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    d545509 View commit details
    Browse the repository at this point in the history

  7. Consolidate switches for matching operators to classes

    @markstory
    markstory committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a08a7f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Improve error handling for invalid operators

    @markstory
    markstory committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8a10b73 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'master' into flagpole-dataclasses

    @markstory
    markstory committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    db744a1 View commit details
    Browse the repository at this point in the history