Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating crash free session alerts #74750

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

saponifi3d
Copy link
Contributor

Description

Fixes #74716

A user reported an issue making crash free session rate alerts, upon investigation it was using a deprecated dataset. This updates the alert UI to use the correct dataset (which fixes the save issue)

@saponifi3d saponifi3d requested a review from a team as a code owner July 23, 2024 18:08
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 23, 2024
Copy link
Contributor

@nhsiehgit nhsiehgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@saponifi3d saponifi3d enabled auto-merge (squash) July 23, 2024 18:11
Copy link

codecov bot commented Jul 23, 2024

Bundle Report

Changes will increase total bundle size by 64 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 28.18MB 64 bytes ⬆️

@saponifi3d saponifi3d merged commit 76eafc4 into master Jul 23, 2024
43 of 44 checks passed
@saponifi3d saponifi3d deleted the jcallender/fix-crash-free-session-alerts branch July 23, 2024 18:22
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (26e6464) to head (d82ec59).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74750      +/-   ##
==========================================
- Coverage   78.14%   78.14%   -0.01%     
==========================================
  Files        6730     6730              
  Lines      300110   300110              
  Branches    51623    51623              
==========================================
- Hits       234529   234527       -2     
- Misses      59256    59261       +5     
+ Partials     6325     6322       -3     
Files Coverage Δ
static/app/views/alerts/wizard/options.tsx 75.47% <ø> (ø)
static/app/views/alerts/wizard/index.tsx 87.75% <0.00%> (-4.09%) ⬇️

... and 2 files with indirect coverage changes

@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save Crash Free Session rate alert
2 participants