[CapMan visibility] Separates rejecting policy and throttling policy in Sentry tags and spans #74733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for a query to be in the throttling zone for an allocation policy in Snuba, and also in another allocation policy's rejection zone. In which case we see the following:
How could the
throttle_threshold
be higher than therejection_threshold
? This is due to the query being throttled by an allocation policy with a throttle threshold of 292000000000, but it's also rejected byConcurrentRateLimitAllocationPolicy
The mismatch is caused by not separating out the rejection policy and the throttle policy when creating Sentry tags and spans.