feat(tracing): reparent ssr spans under pageload txn and under browser request span #74675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r spans if present feat(trace): reparent ssr txns under pageload and browser request spans
github-actions
bot
added
the
Scope: Frontend
JonasBa
commented
Jul 22, 2024
| /** | ||
| * Swaps the two nodes in the graph. | ||
| */ | ||
| function childParentSwap({ |
There was a problem hiding this comment.
This is a bit more annoying than I would like. Tldr, but because the child nodes keep a reference to the parent, it means we need to filter out the children part of the tree so that we dont end up with circular references.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74675 +/- ##
===========================================
- Coverage 88.33% 78.13% -10.20%
===========================================
Files 2930 6729 +3799
Lines 182485 299941 +117456
Branches 32513 51583 +19070
===========================================
+ Hits 161201 234371 +73170
- Misses 15371 59252 +43881
- Partials 5913 6318 +405
|
lforst
approved these changes
Jul 23, 2024
static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
Outdated
Show resolved
Hide resolved
Abdkhan14
reviewed
Jul 23, 2024
static/app/views/performance/newTraceDetails/traceModels/traceTree.tsx
Outdated
Show resolved
Hide resolved
Abdkhan14
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements required changes for getsentry/rfcs#138