feat(utils): Add core CircuitBreaker functionality
#74560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74560 +/- ##
==========================================
+ Coverage 78.14% 78.15% +0.01%
==========================================
Files 6731 6731
Lines 300214 300243 +29
Branches 51642 51646 +4
==========================================
+ Hits 234608 234664 +56
+ Misses 59285 59256 -29
- Partials 6321 6323 +2
|
vartec
approved these changes
Jul 19, 2024
Comment on lines
+253
to
+256
| try: | ||
| self._set_in_redis( | ||
| [ | ||
| (self.broken_state_key, broken_state_expiry, broken_state_timeout), | ||
| (self.recovery_state_key, recovery_state_expiry, recovery_state_timeout), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Having get and set separate might lead to some concurrency weirdness, but I think the worst that can happen is it gets set to BROKEN multiple times in the same moment, which is fine.
lobsterkatie
force-pushed
the
kmclb-add-helpers-to-CircuitBreaker-class
branch
from
55205da
to
20822f6
Compare
lobsterkatie
force-pushed
the
kmclb-add-core-CircuitBreaker-methods
branch
from
6bd2c86
to
526edc4
Compare
lobsterkatie
force-pushed
the
kmclb-add-helpers-to-CircuitBreaker-class
branch
from
9b4a941
to
d5c9975
Compare
lobsterkatie
force-pushed
the
kmclb-add-core-CircuitBreaker-methods
branch
from
e0d7108
to
347a4b1
Compare
lobsterkatie
force-pushed
the
kmclb-add-core-CircuitBreaker-methods
branch
from
46f8edb
to
347a4b1
Compare
lobsterkatie
force-pushed
the
kmclb-add-helpers-to-CircuitBreaker-class
branch
from
8609b63
to
df575da
Compare
lobsterkatie
force-pushed
the
kmclb-add-core-CircuitBreaker-methods
branch
from
347a4b1
to
a6d8786
Compare
This was referenced Jul 23, 2024
lobsterkatie
added a commit
that referenced
this pull request
Jul 23, 2024
#74559) This is a follow-up to #74557, which added the beginnings of a rate-limit-based circuit breaker, in the form of a new `CircuitBreaker` class. In this PR, various helpers, for checking the state of the breaker and the underlying rate limiters and for communicating with redis, have been added to the class. It also adds a `MockCircuitBreaker` subclass for use in tests, which contains a number of methods for mocking both circuit breaker and rate limiter state. Note that though these helpers don't have accompanying tests, they are tested (indirectly) in the final PR in the series[1], as part of testing the methods which use them. [1] #74560
Base automatically changed from
kmclb-add-helpers-to-CircuitBreaker-class
to
master
July 23, 2024 18:07
An error occurred while trying to automatically change base from
kmclb-add-helpers-to-CircuitBreaker-class
to
master
July 23, 2024 18:07
lobsterkatie
force-pushed
the
kmclb-add-core-CircuitBreaker-methods
branch
from
a6d8786
to
1713e4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work, started in #74557 and #74559, of adding a new, class-and-rate-limit-based circuit breaker implementation to the codebase. In this PR, the core
record_errorandshould_allow_requestmethods are added to theCircuitBreakerclass, along with accompaying tests.