feat(metrics): allow wildcards in metrics search bar #74332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will decrease total bundle size by 20 bytes ⬇️
|
vgrozdanic
approved these changes
Jul 16, 2024
ArthurKnaus
reviewed
Jul 16, 2024
| @@ -129,7 +129,6 @@ export function MetricSearchBar({ | |||
| placeholder={t('Filter by tags')} | |||
| query={query} | |||
| savedSearchType={SavedSearchType.METRIC} | |||
| disallowWildcard | |||
There was a problem hiding this comment.
Just to double check: This component is also used in alerts, where we use the event-stats endpoint.
Will is work also there?
ArthurKnaus
approved these changes
Jul 16, 2024
shellmayr
deleted the
shellmayr/feat/re-allow-wildcards-in-metrics-search
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcards were previously dis-allowed in #69644 due to #69387
With getsentry/snuba#5972 being merged, wildcards now work and can be re-allowed in the UI