Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(replay): log rrweb_event_count to slow clicks table #74277

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 15, 2024

@billyvg helps us query for a distribution chart of # of events in a replay

@aliu39 aliu39 marked this pull request as ready for review July 15, 2024 15:55
@aliu39 aliu39 requested a review from a team as a code owner July 15, 2024 15:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 15, 2024
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment inside the info block can be removed but otherwise LGTM.

# Logging to the sentry.replays.slow_click namespace because
# its the only one configured to use BigQuery at the moment.
#
# NOTE: Needs an ops request if we want to create a new dataset.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the ops request comment mean? @cmanallen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore it. Its a note about the destination table name: "sentry.replays.slow_click". It can be removed.

@aliu39 aliu39 enabled auto-merge (squash) July 15, 2024 15:57
@aliu39 aliu39 disabled auto-merge July 15, 2024 15:57
@aliu39 aliu39 enabled auto-merge (squash) July 15, 2024 16:11
@aliu39 aliu39 merged commit 2fe1dfa into master Jul 15, 2024
49 checks passed
@aliu39 aliu39 deleted the aliu/rrweb-metrics branch July 15, 2024 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants