feat(grouping): Method to upgrade deprecated configs #74203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow upgrading project with a grouping configuration that has been marked as depecrated. The project will also get the auto updates config set to `True` to prevent them from falling behind.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jul 12, 2024
src/sentry/grouping/ingest/config.py
Outdated
| @@ -17,6 +17,17 @@ | |||
|
|
|||
| Job = MutableMapping[str, Any] | |||
|
|
|||
| # We are moving all projects off these configuration without waiting for events | |||
| CONFIGS_TO_DEPRECATE = [] | |||
There was a problem hiding this comment.
When we're ready, we will add the mobile config here.
src/sentry/grouping/ingest/config.py
Outdated
| @@ -27,7 +38,9 @@ def _project_should_update_grouping(project: Project) -> bool: | |||
| should_update_org = ( | |||
| project.organization_id % 1000 < float(settings.SENTRY_GROUPING_AUTO_UPDATE_ENABLED) * 1000 | |||
| ) | |||
| return bool(project.get_option("sentry:grouping_auto_update")) and should_update_org | |||
| deprecated_config = project.get_option("sentry:grouping_config") in CONFIGS_TO_DEPRECATE | |||
There was a problem hiding this comment.
This code is reached when we save an error event, thus, we will also upgrade during ingestion:
sentry/src/sentry/event_manager.py
Line 1400 in 233ccd6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74203 +/- ##
==========================================
+ Coverage 78.19% 78.21% +0.01%
==========================================
Files 6660 6664 +4
Lines 297414 297562 +148
Branches 51184 51200 +16
==========================================
+ Hits 232576 232731 +155
+ Misses 58523 58519 -4
+ Partials 6315 6312 -3
|
Co-authored-by: Katie Byers <[email protected]>
Co-authored-by: Katie Byers <[email protected]>
lobsterkatie
approved these changes
Jul 12, 2024
armenzg
added a commit
that referenced
this pull request
Jul 22, 2024
When events come in for projects with the mobile grouping config, they will start transitioning to the latest project config. Once we can run the one-off script in GoCD, we can also transition projects without any events. This takes advantage of the feature added in #74203.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow upgrading projects with a grouping configuration marked as deprecated. The project will also get the auto updates config set to
Trueto prevent them from falling behind.This PR is to run the upgrades.