Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: use absolute imports for BaseManager #72965

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented Jun 18, 2024

fixing an __init__.py cycle one step at a time

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (5d711ca) to head (092daf4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72965   +/-   ##
=======================================
  Coverage   77.97%   77.98%           
=======================================
  Files        6616     6615    -1     
  Lines      295310   295343   +33     
  Branches    50887    50887           
=======================================
+ Hits       230280   230310   +30     
- Misses      58739    58740    +1     
- Partials     6291     6293    +2     
Files Coverage Δ
src/sentry/db/models/__init__.py 100.00% <ø> (ø)
src/sentry/db/models/base.py 91.32% <100.00%> (-0.04%) ⬇️
src/sentry/db/models/outboxes.py 81.10% <100.00%> (+0.08%) ⬆️
src/sentry/db/models/paranoia.py 100.00% <100.00%> (ø)
src/sentry/discover/models.py 94.31% <100.00%> (+0.06%) ⬆️
src/sentry/incidents/models/alert_rule.py 95.38% <100.00%> (ø)
.../sentry/incidents/models/alert_rule_activations.py 93.47% <100.00%> (ø)
src/sentry/incidents/models/incident.py 98.00% <100.00%> (ø)
src/sentry/models/activity.py 90.74% <100.00%> (+0.08%) ⬆️
src/sentry/models/apiapplication.py 95.18% <100.00%> (+0.05%) ⬆️
... and 43 more

... and 6 files with indirect coverage changes

fixing an __init__.py cycle one step at a time
@asottile-sentry asottile-sentry force-pushed the asottile-base-manager-absolute-import branch from 230bf79 to 092daf4 Compare June 20, 2024 13:42
@asottile-sentry asottile-sentry marked this pull request as ready for review June 20, 2024 13:42
@asottile-sentry asottile-sentry requested review from a team as code owners June 20, 2024 13:42
@asottile-sentry asottile-sentry requested review from a team June 20, 2024 13:42
@asottile-sentry asottile-sentry enabled auto-merge (squash) June 20, 2024 14:28
@asottile-sentry asottile-sentry merged commit 5b00015 into master Jun 20, 2024
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-base-manager-absolute-import branch June 20, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants