Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-builder): Remove [me,my_teams,none] suggestion from assigned #72915

Merged

Conversation

malwilley
Copy link
Member

We want to keep this as a suggestion for the old search bar, but for the new one we need to remove it because it handles multiple selection differently.

@malwilley malwilley requested a review from a team June 17, 2024 23:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Bundle Report

Changes will increase total bundle size by 90 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.29MB 90 bytes ⬆️

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (3ff7bb7) to head (e105c1d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72915      +/-   ##
==========================================
- Coverage   78.04%   78.04%   -0.01%     
==========================================
  Files        6605     6605              
  Lines      294458   294457       -1     
  Branches    50764    50764              
==========================================
- Hits       229819   229818       -1     
+ Misses      58305    58304       -1     
- Partials     6334     6335       +1     
Files Coverage Δ
static/app/utils/withIssueTags.tsx 89.65% <100.00%> (-0.35%) ⬇️

... and 1 file with indirect coverage changes

@malwilley malwilley merged commit 81dc21b into master Jun 18, 2024
43 checks passed
@malwilley malwilley deleted the malwilley/fix/query-builder-multiple-assignee-suggestion branch June 18, 2024 16:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants