Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: fix various types for sentry.monitors #72892

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

asottile-sentry
Copy link
Member

No description provided.

@asottile-sentry asottile-sentry requested review from a team June 17, 2024 21:00
@asottile-sentry asottile-sentry requested a review from a team as a code owner June 17, 2024 21:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (fe8da9b) to head (db65a95).
Report is 1 commits behind head on master.

Current head db65a95 differs from pull request most recent head 2729b8e

Please upload reports for the commit 2729b8e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72892       +/-   ##
===========================================
+ Coverage   47.53%   78.04%   +30.51%     
===========================================
  Files        6628     6604       -24     
  Lines      296612   294421     -2191     
  Branches    51085    50757      -328     
===========================================
+ Hits       140999   229786    +88787     
+ Misses     150499    58303    -92196     
- Partials     5114     6332     +1218     
Files Coverage Δ
src/sentry/monitors/clock_tasks/check_missed.py 100.00% <100.00%> (+48.48%) ⬆️
.../sentry/monitors/endpoints/base_monitor_details.py 86.55% <100.00%> (+45.37%) ⬆️
...tors/endpoints/organization_monitor_index_stats.py 92.75% <100.00%> (ø)
src/sentry/monitors/serializers.py 98.85% <100.00%> (+18.28%) ⬆️

... and 4108 files with indirect coverage changes

@asottile-sentry asottile-sentry force-pushed the asottile-typing-minotirs branch from db65a95 to 2729b8e Compare July 1, 2024 17:17
@asottile-sentry asottile-sentry merged commit 81265bc into master Jul 1, 2024
48 checks passed
@asottile-sentry asottile-sentry deleted the asottile-typing-minotirs branch July 1, 2024 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants