Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(related_issues): Prevent race condition #72036

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Jun 4, 2024

When fetching events, oneOtherIssueEvent is undefined, thus, we need to wait until we're certain that the fetch has been completed to prevent rendering twice or the wrong state.

I introduced this problem in #71999.

When fetching events, `oneOtherIssueEvent` is `undefined`, thus, we need to wait until we're certain that the fetch has completed to prevent rendering twice or the wrong state.
@armenzg armenzg self-assigned this Jun 4, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 4, 2024
@armenzg armenzg requested a review from scttcper June 4, 2024 18:56
@armenzg armenzg marked this pull request as ready for review June 4, 2024 18:56
@armenzg armenzg requested a review from a team as a code owner June 4, 2024 18:56
@armenzg armenzg enabled auto-merge (squash) June 4, 2024 19:16
@armenzg armenzg merged commit 9ce10ba into master Jun 4, 2024
43 checks passed
@armenzg armenzg deleted the fix/race-condition/related_issues/armenzg branch June 4, 2024 19:39
@armenzg armenzg removed the request for review from scttcper June 4, 2024 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants