Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(similarity): Add read only flag to NN endpoint #72021

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

jangjodi
Copy link
Member

@jangjodi jangjodi commented Jun 4, 2024

Add read_only flag to get_nearest_neighbor endpoint

@jangjodi jangjodi requested a review from a team June 4, 2024 17:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 4, 2024
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this not a parameter that's passed in, but just default? any situation where we'd want to run embeddings if the endpoint is hit?

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (20e4b53) to head (3fdabb3).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #72021       +/-   ##
===========================================
+ Coverage   56.88%   77.91%   +21.02%     
===========================================
  Files        6562     6572       +10     
  Lines      292299   292722      +423     
  Branches    50462    50533       +71     
===========================================
+ Hits       166273   228061    +61788     
+ Misses     121283    58408    -62875     
- Partials     4743     6253     +1510     
Files Coverage Δ
...y/api/endpoints/group_similar_issues_embeddings.py 100.00% <ø> (+47.36%) ⬆️
src/sentry/seer/similarity/types.py 100.00% <100.00%> (+17.30%) ⬆️

... and 1969 files with indirect coverage changes

@jangjodi jangjodi merged commit 303dfcb into master Jun 4, 2024
49 checks passed
@jangjodi jangjodi deleted the jodi/read-only-get-NN branch June 4, 2024 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants