fix(issues): Fix missing retries configuration #70907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This previously was being logged but not actually configured anywhere. There is no change in behavior due to this since this value is configured to 1 and the default urllib3 behavior is also 1 for POST methods - the docs state 3 but that isn't applied to all methods: https://github.com/urllib3/urllib3/blob/main/src/urllib3/util/retry.py#L184
github-actions
bot
added
the
Scope: Backend
vartec
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously was being logged (see also #70892) but not actually configured anywhere.
There is no change in behavior since this value is configured to 1 and the default urllib3 behavior is also 1 for POST methods, despite the docs stating 3 it isn't applied to all methods: https://github.com/urllib3/urllib3/blob/main/src/urllib3/util/retry.py#L184