Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): queues module table sorting #70817

Merged
merged 14 commits into from
May 15, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented May 13, 2024

Updates Queues module tables to allow sorting and updates the Time Spent column

  • Updates Queues module landing page and destination summary tables to allow sorting by clicking column headers
  • Update Time Spent columns to display a tooltip. Updates and utilizes the time_spent_percentage function.
  • Also fixes minor loading state bug for metrics ribbons

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 13, 2024
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review May 14, 2024 14:13
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner May 14, 2024 14:13
…om:getsentry/sentry into egou/feat/queues-module-table-sorting
Base automatically changed from egou/feat/queues-module-destination-search to master May 14, 2024 19:44
Copy link

codecov bot commented May 14, 2024

Bundle Report

Changes will increase total bundle size by 3.88kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.8MB 3.88kB ⬆️

@edwardgou-sentry edwardgou-sentry merged commit 47e08b8 into master May 15, 2024
41 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/queues-module-table-sorting branch May 15, 2024 14:27
Copy link

sentry-io bot commented May 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�[22mtoHaveBeenCalledWith�[2m(�[22m�[32m...expected�[39m... Object.?(transactionsTable.spec.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants