ref(py): Update monitor_consumer to handle FilteredPayload #69904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
changed the title
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Apr 29, 2024
This is primarily a typing adjustment. Since we're not actually using FilterStep we're never going to actualy get a FilteredPayload.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-py-update-monitor-consumer-to-handle-filteredpayload
branch
from
46bbb94
to
532ebdb
Compare
lynnagara
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69904 +/- ##
===========================================
+ Coverage 58.33% 79.84% +21.50%
===========================================
Files 6478 6489 +11
Lines 288115 288559 +444
Branches 49632 49688 +56
===========================================
+ Hits 168086 230409 +62323
+ Misses 119626 57752 -61874
+ Partials 403 398 -5
|
evanpurkhiser
deleted the
evanpurkhiser/ref-py-update-monitor-consumer-to-handle-filteredpayload
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily a typing adjustment. Since we're not using
FilterStepwe're never going to actually get aFilteredPayload.