Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ddm): Add message to the block metric confirm modal #69184

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(ddm): Add message to the block metric confirm modal #69184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions static/app/views/settings/projectMetrics/projectMetricsDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,13 @@ function ProjectMetricsDetails({project, params, organization}: Props) {
isBlocked={isBlockedMetric}
onConfirm={handleMetricBlockToggle}
aria-label={t('Block Metric')}
message={
isBlockedMetric
? t('Are you sure you want to unblock this metric?')
: t(
'Are you sure you want to block this metric? It will no longer be ingested, and will not be available for use in Metrics, Alerts, or Dashboards.'
)
}
/>
<LinkButton
to={getMetricsUrl(organization.slug, {
Expand Down
Loading