Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hc): Handles sentry app permission check where org is not found #69175

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

GabeVillalobos
Copy link
Member

Adds an additional log and explicit handling for a permission check failure due to an Organization lookup failure.

This will help us triage an ongoing issue with sentry apps in EU region.

@GabeVillalobos GabeVillalobos requested a review from a team as a code owner April 18, 2024 03:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2024
@GabeVillalobos GabeVillalobos requested a review from a team April 18, 2024 03:17
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.70%. Comparing base (86c6aa6) to head (8dcb0d8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69175      +/-   ##
==========================================
- Coverage   79.70%   79.70%   -0.01%     
==========================================
  Files        6421     6421              
  Lines      285320   285325       +5     
  Branches    49161    49162       +1     
==========================================
+ Hits       227420   227422       +2     
- Misses      57464    57467       +3     
  Partials      436      436              
Files Coverage Δ
src/sentry/api/bases/sentryapps.py 95.54% <60.00%> (-0.74%) ⬇️

... and 4 files with indirect coverage changes

@GabeVillalobos GabeVillalobos merged commit a959af6 into master Apr 18, 2024
49 of 50 checks passed
@GabeVillalobos GabeVillalobos deleted the gv/add-logging-to-missing-org-for-sentry-app branch April 18, 2024 15:57
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants