Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): Minor fixes to Requests view I #69156

Merged
merged 7 commits into from
Apr 18, 2024
Merged

feat(perf): Minor fixes to Requests view I #69156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
058cffb
Fix layout
gggritso Apr 17, 2024
e8d3a7a
Provide correct span op
gggritso Apr 17, 2024
d6d72f7
`formatPercentage` `minimumValue` option
gggritso Apr 17, 2024
c5eb380
Support minimum values in metric readouts
gggritso Apr 17, 2024
222032c
Add bottom padding to detail panel
gggritso Apr 17, 2024
0f5525e
Revert "`formatPercentage` `minimumValue` option"
gggritso Apr 17, 2024
dee6b33
Revert "Support minimum values in metric readouts"
gggritso Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions static/app/views/performance/http/domainTransactionsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,12 @@ function renderBodyCell(

const renderer = getFieldRenderer(column.key, meta.fields, false);

return renderer(row, {
location,
organization,
unit: meta.units?.[column.key],
});
return renderer(
{...row, 'span.op': 'http.client'},
{
location,
organization,
unit: meta.units?.[column.key],
}
);
}
16 changes: 11 additions & 5 deletions static/app/views/performance/http/domainsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,15 @@ function renderBodyCell(

const renderer = getFieldRenderer(column.key, meta.fields, false);

return renderer(row, {
location,
organization,
unit: meta.units?.[column.key],
});
return renderer(
{
'span.op': 'http.client',
...row,
},
{
location,
organization,
unit: meta.units?.[column.key],
}
);
}
2 changes: 1 addition & 1 deletion static/app/views/performance/http/httpDomainSummaryPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export function HTTPDomainSummaryPage() {
unit={DurationUnit.MILLISECOND}
tooltip={getTimeSpentExplanation(
domainMetrics?.[0]?.['time_spent_percentage()'],
'db'
'http'
)}
isLoading={areDomainMetricsLoading}
/>
Expand Down
4 changes: 3 additions & 1 deletion static/app/views/performance/http/httpLandingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ export function HTTPLandingPage() {
</ModuleLayout.Full>

{onboardingProject && (
<Onboarding organization={organization} project={onboardingProject} />
<ModuleLayout.Full>
<Onboarding organization={organization} project={onboardingProject} />
</ModuleLayout.Full>
)}

{!onboardingProject && (
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/performance/http/httpSamplesPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ export function HTTPSamplesPanel() {
unit={DurationUnit.MILLISECOND}
tooltip={getTimeSpentExplanation(
domainTransactionMetrics?.[0]?.['time_spent_percentage()'],
'db'
'http.client'
)}
isLoading={areDomainTransactionMetricsFetching}
/>
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/starfish/components/detailPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,5 @@ const CloseButtonWrapper = styled('div')`
`;

const DetailWrapper = styled('div')`
padding: 0 ${space(4)};
padding: 0 ${space(4)} ${space(4)};
`;
Loading