Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hybridcloud) Remove outbox based webhooks #66158

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

markstory
Copy link
Member

With webhookpayload handling all of the webhook deliveries now we can remove the outbox based storage path. Once this is deployed I'll remove the outbox receiver and other related functionality.

With webhookpayload handling all of the webhook deliveries now we can
remove the outbox based storage path. Once this is deployed I'll remove
the outbox receiver and other related functionality.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (6a2bf49) to head (47a0dce).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66158      +/-   ##
==========================================
- Coverage   84.31%   84.29%   -0.02%     
==========================================
  Files        5308     5308              
  Lines      237319   237388      +69     
  Branches    41044    41047       +3     
==========================================
+ Hits       200092   200111      +19     
- Misses      37009    37058      +49     
- Partials      218      219       +1     
Files Coverage Δ
src/sentry/middleware/integrations/parsers/base.py 92.12% <100.00%> (-0.53%) ⬇️
src/sentry/testutils/outbox.py 60.81% <ø> (-19.71%) ⬇️

... and 99 files with indirect coverage changes

Copy link
Member

@GabeVillalobos GabeVillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 Nice work!

@markstory markstory merged commit ddfa40f into master Mar 15, 2024
49 checks passed
@markstory markstory deleted the chore-webhook-outbox branch March 15, 2024 13:44
JonasBa pushed a commit that referenced this pull request Mar 17, 2024
With webhookpayload handling all of the webhook deliveries now we can
remove the outbox based storage path. Once this is deployed I'll remove
the outbox receiver and other related functionality.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants