Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics_extraction): user_misery to fall back to Discover #65232

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Feb 15, 2024

Unfortunately, the count unique field we have been using is user.id which does not match what Discover uses, thus, the data return diverges.

We need to do some work on Relay in order to have the same user field available to on-demand. Until then we will be dropping support for user_misery in on-demand.

Unfortunately, the count unique field we have been using is `user.id` which does not match what Discover uses, thus, the data return diverges.

We need to do some work on Relay in order to have the same `user` field available to on-demand. Until then we will be dropping support for `user_misery` in on-demand.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 15, 2024
@armenzg armenzg requested a review from k-fish February 15, 2024 13:45
@armenzg armenzg self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5486d69) 81.42% compared to head (13db3e7) 81.42%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #65232      +/-   ##
==========================================
- Coverage   81.42%   81.42%   -0.01%     
==========================================
  Files        5254     5254              
  Lines      232170   232136      -34     
  Branches    45525    45517       -8     
==========================================
- Hits       189055   189024      -31     
+ Misses      37246    37240       -6     
- Partials     5869     5872       +3     
Files Coverage Δ
src/sentry/models/project.py 95.75% <ø> (ø)
src/sentry/snuba/metrics/extraction.py 90.90% <ø> (-0.73%) ⬇️
...nents/modals/widgetBuilder/addToDashboardModal.tsx 82.60% <ø> (+1.35%) ⬆️
static/app/components/modals/widgetViewerModal.tsx 77.31% <ø> (ø)
...modals/widgetViewerModal/widgetViewerTableCell.tsx 75.36% <ø> (ø)
static/app/components/replays/replayContext.tsx 54.87% <ø> (+4.35%) ⬆️
static/app/constants/index.tsx 94.44% <ø> (ø)
static/app/views/dashboards/dashboard.tsx 70.94% <ø> (+0.55%) ⬆️
static/app/views/dashboards/datasetConfig/base.tsx 93.33% <ø> (-0.79%) ⬇️
static/app/views/dashboards/detail.tsx 56.65% <ø> (+0.06%) ⬆️
... and 16 more

... and 7 files with indirect coverage changes

@armenzg armenzg marked this pull request as ready for review February 15, 2024 14:23
@armenzg armenzg requested review from a team as code owners February 15, 2024 14:23
@armenzg armenzg enabled auto-merge (squash) February 15, 2024 14:25
@armenzg armenzg merged commit 55c7b17 into master Feb 15, 2024
49 checks passed
@armenzg armenzg deleted the feat/fall_back_user_misery/metrics/extraction/armenzg branch February 15, 2024 16:38
armenzg added a commit that referenced this pull request Feb 22, 2024
armenzg added a commit that referenced this pull request Feb 22, 2024
armenzg added a commit that referenced this pull request Feb 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants