-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics_extraction): user_misery to fall back to Discover #65232
Merged
armenzg
merged 3 commits into
master
from
feat/fall_back_user_misery/metrics/extraction/armenzg
Feb 15, 2024
Merged
feat(metrics_extraction): user_misery to fall back to Discover #65232
armenzg
merged 3 commits into
master
from
feat/fall_back_user_misery/metrics/extraction/armenzg
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, the count unique field we have been using is `user.id` which does not match what Discover uses, thus, the data return diverges. We need to do some work on Relay in order to have the same `user` field available to on-demand. Until then we will be dropping support for `user_misery` in on-demand.
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Feb 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65232 +/- ##
==========================================
- Coverage 81.42% 81.42% -0.01%
==========================================
Files 5254 5254
Lines 232170 232136 -34
Branches 45525 45517 -8
==========================================
- Hits 189055 189024 -31
+ Misses 37246 37240 -6
- Partials 5869 5872 +3
|
snigdhas
approved these changes
Feb 15, 2024
k-fish
approved these changes
Feb 15, 2024
armenzg
deleted the
feat/fall_back_user_misery/metrics/extraction/armenzg
branch
February 15, 2024 16:38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the count unique field we have been using is
user.id
which does not match what Discover uses, thus, the data return diverges.We need to do some work on Relay in order to have the same
user
field available to on-demand. Until then we will be dropping support foruser_misery
in on-demand.