feat(issue-details): Show static replay when error is not within the replay #64827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Feb 7, 2024
static/app/components/events/eventReplay/replayPreview.spec.tsx
Outdated
Show resolved
Hide resolved
scttcper
reviewed
Feb 7, 2024
static/app/components/events/eventReplay/staticReplayPreview.tsx
Outdated
Show resolved
Hide resolved
scttcper
reviewed
Feb 7, 2024
static/app/components/events/eventReplay/replayPreview.spec.tsx
Outdated
Show resolved
Hide resolved
scttcper
approved these changes
Feb 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers an edge case when the error event is not within the bounds of the replay. I don't know how prevalent this is, but it has happened at least once (see here for an example).
My solution is to fall back to the static replay preview component. I extracted the success state from the existing one into a new component so it can be used in the new clip component as well.