feat(ddm): Add new metrics/query endpoint base code #64785
Conversation
github-actions
bot
added
the
Scope: Backend
| @@ -0,0 +1,61 @@ | |||
| from collections.abc import Sequence | |||
There was a problem hiding this comment.
Copied the entire code in data to make the new changes completely independent of the old ones. Should enable us to keep the old endpoint up and running without problems.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| referrer=Referrer.API_DDM_METRICS_QUERY.value, | ||
| ) | ||
| except InvalidMetricsQueryError as e: | ||
| return Response(status=400, data={"detail": str(e)}) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| except InvalidMetricsQueryError as e: | ||
| return Response(status=400, data={"detail": str(e)}) | ||
| except LatestReleaseNotFoundError as e: | ||
| return Response(status=404, data={"detail": str(e)}) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| except LatestReleaseNotFoundError as e: | ||
| return Response(status=404, data={"detail": str(e)}) | ||
| except MetricsQueryExecutionError as e: | ||
| return Response(status=500, data={"detail": str(e)}) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
| @@ -201,6 +201,15 @@ class OrgAuthTokenPermission(OrganizationPermission): | |||
| } | |||
|
|
|||
|
|
|||
| class OrganizationMetricsPermission(OrganizationPermission): | |||
There was a problem hiding this comment.
We needed different permissions since by default we don't have org:read on POST.
| # TODO: figure out how to make these methods work with HTTP body. | ||
| projects=self.get_projects(request, organization), | ||
| environments=self.get_environments(request, organization), | ||
| referrer=Referrer.API_DDM_METRICS_QUERY.value, |
There was a problem hiding this comment.
Created a different referrer to separately track in snuba the usage of the new endpoint.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #64785 +/- ##
==========================================
+ Coverage 81.36% 81.37% +0.01%
==========================================
Files 5236 5243 +7
Lines 231130 231453 +323
Branches 45348 45400 +52
==========================================
+ Hits 188058 188347 +289
- Misses 37220 37252 +32
- Partials 5852 5854 +2
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This PR adds a new
/metrics/queryendpoint and copies over all thequerying/datafiles inquerying/data_v2to kickstart the development of the updated metrics API.Closes: #64769