ref/tests(metrics_extraction): Reduce changes when adjusting spec versions #63947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armenzg
changed the title
armenzg
force-pushed
the
ref/test_changes/metrics_extraction/armenzg
branch
from
01f39f0
to
820bdbb
Compare
armenzg
commented
Jan 26, 2024
| @@ -122,14 +122,17 @@ def test_get_metric_extraction_config_single_alert(default_project: Project) -> | |||
| config = get_metric_extraction_config(default_project) | |||
|
|
|||
| assert config | |||
| assert len(config["metrics"]) == 1 | |||
There was a problem hiding this comment.
In this PR, I'm removing all instances of checking for the length of the metrics if we check for the contents of it right after.
| @@ -122,14 +122,17 @@ def test_get_metric_extraction_config_single_alert(default_project: Project) -> | |||
| config = get_metric_extraction_config(default_project) | |||
|
|
|||
| assert config | |||
| assert len(config["metrics"]) == 1 | |||
| assert config["metrics"][0] == { | |||
There was a problem hiding this comment.
I'm removing accessing indices from config metrics to make diffs easier when adjusting the number of specs.
k-fish
approved these changes
Jan 26, 2024
obostjancic
approved these changes
Jan 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a new spec version for widgets in #63774, this change will make the diff easier when adding and removing spec versions for both alerts and widgets.