Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ddm): Rename the files for metrics metadata #63931

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Jan 26, 2024

This PR renames all the files for metrics metadata with the metrics_* prefix to make them faster to recognize and disambiguate.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 26, 2024
@iambriccardo iambriccardo marked this pull request as ready for review January 26, 2024 10:07
@iambriccardo iambriccardo requested a review from a team as a code owner January 26, 2024 10:08
@iambriccardo iambriccardo enabled auto-merge (squash) January 26, 2024 10:10
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbb5661) 81.39% compared to head (8730520) 81.39%.
Report is 3 commits behind head on master.

❗ Current head 8730520 differs from pull request most recent head 1c26bcf. Consider uploading reports for the commit 1c26bcf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #63931   +/-   ##
=======================================
  Coverage   81.39%   81.39%           
=======================================
  Files        5227     5227           
  Lines      232447   232447           
  Branches    40248    40248           
=======================================
  Hits       189205   189205           
- Misses      37390    37393    +3     
+ Partials     5852     5849    -3     
Files Coverage Δ
src/sentry/api/endpoints/organization_ddm.py 94.73% <100.00%> (ø)
...y/api/serializers/models/metrics_code_locations.py 100.00% <100.00%> (ø)
...try/api/serializers/models/metrics_correlations.py 100.00% <100.00%> (ø)
...etrics/querying/metadata/metrics_code_locations.py 93.00% <ø> (ø)
..._metrics/querying/metadata/metrics_correlations.py 81.81% <ø> (ø)

... and 7 files with indirect coverage changes

@iambriccardo iambriccardo merged commit 5d2810f into master Jan 26, 2024
49 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/metadata-names branch January 26, 2024 11:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants