feat: apitoken last characters option #62972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62972 +/- ##
==========================================
- Coverage 81.35% 81.35% -0.01%
==========================================
Files 5203 5203
Lines 230613 230620 +7
Branches 39847 39848 +1
==========================================
- Hits 187615 187614 -1
- Misses 37248 37254 +6
- Partials 5750 5752 +2
|
azaslavsky
reviewed
Jan 11, 2024
azaslavsky
approved these changes
Jan 11, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
mdtro
added a commit
that referenced
this pull request
Jan 17, 2024
Backfills the `token_last_characters` column on existing `ApiToken` entries. As of #62972, new `ApiToken` entries are being created with this column already populated with the correct values. This backfill will only impact old tokens created prior. Tracking Issue: #58918 Related RFC: getsentry/rfcs#32
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
Take two of #59455. - Add an option to toggle on/off automatically populating the `token_last_characters` for the `ApiToken` model. This option will ensure tokens created from here on have the field populated. It will also allow me to thoroughly test the backfill migration needed for existing tokens that will be coming in a future PR by disabling the option in tests, creating a bunch of API tokens, and then running the backfill migration test. Tracking Issue: #58918 RFC: getsentry/rfcs#32
trillville
pushed a commit
that referenced
this pull request
Jan 19, 2024
Backfills the `token_last_characters` column on existing `ApiToken` entries. As of #62972, new `ApiToken` entries are being created with this column already populated with the correct values. This backfill will only impact old tokens created prior. Tracking Issue: #58918 Related RFC: getsentry/rfcs#32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two of #59455.
token_last_charactersfor theApiTokenmodel.This option will ensure tokens created from here on have the field populated. It will also allow me to thoroughly test the backfill migration needed for existing tokens that will be coming in a future PR by disabling the option in tests, creating a bunch of API tokens, and then running the backfill migration test.
Tracking Issue: #58918
RFC: getsentry/rfcs#32