Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hybridcloud) Return early when we can't find organizations #62126

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

markstory
Copy link
Member

When handling webhooks for organization scoped resources we shouldn't bother continuing to process the request or forwarding it to a region if we know that the organization is missing.

Fixes SENTRY-2BDQ
Refs HC-1041

When handling webhooks for organization scoped resources we shouldn't
bother continuing to process the request or forwarding it to a region if
we know that the organization is missing.

Fixes SENTRY-2BDQ
Refs HC-1041
@markstory markstory requested a review from a team December 20, 2023 21:27
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f65d18) 81.22% compared to head (85758c9) 81.22%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #62126      +/-   ##
==========================================
- Coverage   81.22%   81.22%   -0.01%     
==========================================
  Files        5191     5191              
  Lines      229371   229390      +19     
  Branches    39629    39631       +2     
==========================================
+ Hits       186313   186325      +12     
- Misses      37359    37363       +4     
- Partials     5699     5702       +3     
Files Coverage Δ
...c/sentry/middleware/integrations/parsers/plugin.py 91.89% <100.00%> (+14.11%) ⬆️

... and 13 files with indirect coverage changes

@markstory markstory merged commit efd8c94 into master Dec 21, 2023
51 checks passed
@markstory markstory deleted the fix-github-plugin-silo branch December 21, 2023 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants