fix(integrations) Make social auth user update silo safe #62092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't set attributes that don't exist on RpcUser as it causes errors, same with saving. I've not removed the User update entirely as I'm not confident that this isn't sometimes called with User instances that can be updated. Fixes SENTRY-198W
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62092 +/- ##
==========================================
+ Coverage 80.15% 81.22% +1.06%
==========================================
Files 5190 5190
Lines 229285 229287 +2
Branches 39609 39609
==========================================
+ Hits 183777 186230 +2453
+ Misses 39663 37360 -2303
+ Partials 5845 5697 -148 |
mrduncan
approved these changes
Dec 20, 2023
vbro
approved these changes
Dec 20, 2023
dashed
approved these changes
Dec 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't set attributes that don't exist on RpcUser as it causes errors, same with saving. I've not removed the User update entirely as I'm not confident that this isn't sometimes called with User instances that can be updated.
Fixes SENTRY-198W