Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove self-hosted cloudbuild #61727

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

asottile-sentry
Copy link
Member

this is now built in GHA -> ghcr

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 13, 2023
this is now built in GHA -> ghcr
@asottile-sentry asottile-sentry force-pushed the asottile-remove-self-hosted-cloudbuild branch from c71ff42 to 75ebaf7 Compare December 13, 2023 23:41
@asottile-sentry asottile-sentry marked this pull request as ready for review December 13, 2023 23:41
@asottile-sentry asottile-sentry requested a review from a team as a code owner December 13, 2023 23:41
@asottile-sentry asottile-sentry requested review from a team December 13, 2023 23:41
@asottile-sentry asottile-sentry enabled auto-merge (squash) December 13, 2023 23:41
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #61727 (c71ff42) into master (0705c5f) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 72.72%.

❗ Current head c71ff42 differs from pull request most recent head 75ebaf7. Consider uploading reports for the commit 75ebaf7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #61727   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files        5188     5188           
  Lines      228458   228458           
  Branches    38316    38316           
=======================================
+ Hits       185380   185383    +3     
+ Misses      37446    37443    -3     
  Partials     5632     5632           
Files Coverage Δ
...entry/api/endpoints/project_rules_configuration.py 96.66% <100.00%> (ø)
src/sentry/rules/conditions/event_frequency.py 91.76% <100.00%> (ø)
src/sentry/receivers/features.py 85.15% <50.00%> (ø)
src/sentry/receivers/rules.py 95.65% <75.00%> (+13.83%) ⬆️
src/sentry/rules/conditions/high_priority_issue.py 80.64% <50.00%> (-0.61%) ⬇️

... and 8 files with indirect coverage changes

Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@asottile-sentry asottile-sentry merged commit 21dfdf8 into master Dec 14, 2023
46 checks passed
@asottile-sentry asottile-sentry deleted the asottile-remove-self-hosted-cloudbuild branch December 14, 2023 00:02
@hubertdeng123
Copy link
Member

I think removing this broke release build for 23.12.0, so reverting to unblock the release:
https://github.com/getsentry/publish/actions/runs/7254637875/job/19763721097

@hubertdeng123 hubertdeng123 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Dec 18, 2023
@getsentry-bot
Copy link
Contributor

PR reverted: ae39b42

getsentry-bot added a commit that referenced this pull request Dec 18, 2023
This reverts commit 21dfdf8.

Co-authored-by: hubertdeng123 <[email protected]>
@hubertdeng123
Copy link
Member

Still not working here, maybe due to the fact that a google cloud build trigger was deleted? 🤔

hubertdeng123 added a commit that referenced this pull request Dec 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants