Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hybridcloud) Remove externalactor.actor_id #60548

Merged
merged 5 commits into from
Nov 27, 2023
Merged

fix(hybridcloud) Remove externalactor.actor_id #60548

merged 5 commits into from
Nov 27, 2023

Conversation

markstory
Copy link
Member

This field was removed from django state a few months back in #56534 This field is now causing issues in deletions as foreign key constraints are preventing records from being deleted. Removing the unused column seems like the most efficient solution.

Fixes SENTRY-163E

This field was removed from django state a few months back in #56534
This field is now causing issues in deletions as foreign key constraints
are preventing records from being deleted. Removing the unused column
seems like the most efficient solution.

Fixes SENTRY-163E
@markstory markstory requested a review from a team November 24, 2023 16:22
@markstory markstory requested a review from a team as a code owner November 24, 2023 16:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #60548 (11c2214) into master (62877ee) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

❗ Current head 11c2214 differs from pull request most recent head cd3cfa3. Consider uploading reports for the commit cd3cfa3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60548      +/-   ##
==========================================
- Coverage   80.85%   80.85%   -0.01%     
==========================================
  Files        5185     5185              
  Lines      227915   227925      +10     
  Branches    38344    38345       +1     
==========================================
- Hits       184289   184278      -11     
- Misses      38002    38022      +20     
- Partials     5624     5625       +1     

see 15 files with indirect coverage changes

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0607_drop_externalactor_actorid.py ()

--
-- Custom state/database change combination
--

                    ALTER TABLE "sentry_externalactor" DROP COLUMN actor_id;
                    ;

@markstory markstory merged commit 7ed14be into master Nov 27, 2023
49 checks passed
@markstory markstory deleted the fix-163e branch November 27, 2023 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants