Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(notifications): remove unused notification manager methods #60493

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Nov 22, 2023

This PR removes some now unused methods from the notification manager

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #60493 (932a183) into master (24675bb) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60493   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files        5181     5181           
  Lines      227744   227693   -51     
  Branches    38324    38311   -13     
=======================================
- Hits       184137   184100   -37     
+ Misses      37984    37976    -8     
+ Partials     5623     5617    -6     
Files Coverage Δ
src/sentry/notifications/manager.py 82.02% <100.00%> (+2.54%) ⬆️

... and 7 files with indirect coverage changes

@scefali scefali marked this pull request as ready for review November 23, 2023 00:58
@scefali scefali requested a review from a team as a code owner November 23, 2023 00:58
@scefali scefali merged commit 977c751 into master Nov 27, 2023
52 checks passed
@scefali scefali deleted the ref/remove-unused-notification-manager-methods branch November 27, 2023 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants