ref(webvitals): Support for using stored performance scores #60397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
Sorry, this pr touches a lot of files. It's mostly just moving/reorganizing and updating imports. |
shruthilayaj
approved these changes
Nov 24, 2023
|
|
||
| const {data: projectData} = useProjectWebVitalsQuery({transaction}); | ||
| const {data: projectData} = useProjectRawWebVitalsQuery({}); |
There was a problem hiding this comment.
how come these don't need the transaction filter anymore?
There was a problem hiding this comment.
Thanks for the review!
transaction is always undefined in this scenario, so nothing should change here.
This was old branching code from when we had a transaction specific view for the webVitalsDetailPanel when a user clicks on a transaction/page. This went away when we introduced the page overview page.
edwardgou-sentry
deleted the
egou/feat/webvitals-staored-scores-support
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no product feature updates in this pr
USE_STORED_SCORES controls whether the ui uses calculated vs stored performance scores. USE_STORED_SCORES is hard coded to false for now, until all components are updated to support using stored scores.