Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(hc): Handle LazyObjects in serialize_generic_user #60120

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

RyanSkonnord
Copy link
Contributor

Small tweak following #60065.

With the change in #60065, it might be safe not to do this in serialize_generic_user at all, but it's probably better to continue. Doing so by isinstance over hasattr (consistently with #60065) is safer.

@RyanSkonnord RyanSkonnord requested a review from a team as a code owner November 16, 2023 19:21
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #60120 (5f3efa8) into master (32aacd5) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60120   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files        5183     5183           
  Lines      227682   227683    +1     
  Branches    38309    38309           
=======================================
+ Hits       184093   184098    +5     
+ Misses      37968    37963    -5     
- Partials     5621     5622    +1     
Files Coverage Δ
src/sentry/services/hybrid_cloud/user/serial.py 92.15% <100.00%> (+0.15%) ⬆️

... and 3 files with indirect coverage changes

@RyanSkonnord RyanSkonnord merged commit 34d649b into master Nov 21, 2023
51 checks passed
@RyanSkonnord RyanSkonnord deleted the lazy-object-in-serialize-generic-user branch November 21, 2023 18:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants