Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(browser-starfish): add domain selector for img tab in resource module #58937

Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat(browser-starfish): add domain selector for img tab in resource module #58937

merged 2 commits into from
Oct 27, 2023

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Oct 27, 2023 •
edited
Loading

Work towards #58723

  1. Adds a domain selector to the img tab in the resource module (TODO, add some domain wide charts at the top?)
    image
  2. Does some refactoring so that the domain selector is shared.
  3. some more refactoring to clean things up a bit.

@DominikB2014 DominikB2014 requested review from AbhiPrasad and a team October 27, 2023 15:45
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 27, 2023
AbhiPrasad
AbhiPrasad approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@DominikB2014 DominikB2014 enabled auto-merge (squash) October 27, 2023 15:51
@DominikB2014 DominikB2014 merged commit 6ad6766 into master Oct 27, 2023
44 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/add-domain-selector branch October 27, 2023 16:19
@AbhiPrasad AbhiPrasad added this to the Resource Module Internal milestone Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
Resource Module Internal
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikB2014 @AbhiPrasad