Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser-starfish): resource module fails to load decode size #58792

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(browser-starfish): resource module fails to load decode size #58792

merged 1 commit into from
Oct 25, 2023

Conversation

DominikB2014
Copy link
Contributor

Couple of fixes.

  1. Main fix is now the decoded body size is fetched properly
  2. Update the default sort to be throughput
  3. Remove the unused SPAN_OP param from the resource summary query.

@DominikB2014 DominikB2014 requested a review from a team October 25, 2023 19:29
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 25, 2023
@DominikB2014 DominikB2014 enabled auto-merge (squash) October 25, 2023 19:33
@DominikB2014 DominikB2014 merged commit f917193 into master Oct 25, 2023
41 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/resource-module-misc branch October 25, 2023 20:00
@AbhiPrasad AbhiPrasad added this to the Resource Module Internal milestone Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
Resource Module Internal
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikB2014 @AbhiPrasad