feat(browser-starfish): create basic image view #58785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
DominikB2014
commented
Oct 26, 2023
Comment on lines
-1
to
-5
| function ImageResourceView() { | ||
| return <div>Add a sample table here, with some filters</div>; | ||
| } | ||
|
|
||
| export default ImageResourceView; |
There was a problem hiding this comment.
Moved this file to resources/imageView/index
AbhiPrasad
approved these changes
Oct 26, 2023
static/app/views/performance/browser/resources/imageView/utils/useIndexedResourcesQuery.ts
Outdated
Show resolved
Hide resolved
static/app/views/performance/browser/resources/imageView/resourceTable.tsx
Outdated
Show resolved
Hide resolved
AbhiPrasad
reviewed
Oct 26, 2023
static/app/views/performance/browser/resources/imageView/utils/useIndexedResourcesQuery.ts
Outdated
Show resolved
Hide resolved
…/useIndexedResourcesQuery.ts Co-authored-by: Abhijeet Prasad <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the large PR 😅 This works towards #58723