Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discover): add ability to query for avg decoded resource size and transfer size #58770

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Oct 25, 2023

This Pr un-reverts #58275, and makes the appropriate changes so that tests now pass.

You can now query for a resources

  1. http.response_transfer_size
  2. http.decoded_response_body_length

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 25, 2023
@DominikB2014 DominikB2014 requested a review from a team October 25, 2023 16:14
@DominikB2014 DominikB2014 changed the title DOminikB2014/add resource size queries 2 feat(discover): add ability to query for avg decoded resource size and transfer size Oct 25, 2023
@DominikB2014 DominikB2014 marked this pull request as ready for review October 25, 2023 16:15
@DominikB2014 DominikB2014 requested a review from a team as a code owner October 25, 2023 16:15
@DominikB2014 DominikB2014 requested a review from a team October 25, 2023 16:15
@DominikB2014 DominikB2014 requested review from a team as code owners October 25, 2023 16:15
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #58770 (4c7d62c) into master (4773415) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #58770      +/-   ##
==========================================
- Coverage   80.59%   80.58%   -0.01%     
==========================================
  Files        5150     5151       +1     
  Lines      225411   225540     +129     
  Branches    37973    37993      +20     
==========================================
+ Hits       181660   181760     +100     
- Misses      38191    38221      +30     
+ Partials     5560     5559       -1     
Files Coverage Δ
src/sentry/search/events/constants.py 100.00% <ø> (ø)
src/sentry/snuba/metrics/naming_layer/mri.py 93.98% <100.00%> (+0.09%) ⬆️
src/sentry/snuba/metrics/naming_layer/public.py 100.00% <100.00%> (ø)
src/sentry/testutils/cases.py 85.79% <ø> (ø)

... and 94 files with indirect coverage changes

@DominikB2014 DominikB2014 merged commit 8ac76eb into master Oct 25, 2023
52 checks passed
@DominikB2014 DominikB2014 deleted the DOminikB2014/add-resource-size-queries-2 branch October 25, 2023 17:21
@AbhiPrasad AbhiPrasad added this to the Resource Module Internal milestone Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants