fix(workflow): Restyle notification overrides and project picker #58638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Groups projects by my projects / all projects - Adds a minimum height since the dropdown gets weird at the bottom of the page - Adds loading/error states
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Oct 24, 2023
| <LoadingError onRetry={refetch} /> | ||
| </PanelBody> | ||
| )} | ||
| <StyledPanelBody>{renderOverrides()}</StyledPanelBody> |
There was a problem hiding this comment.
Probably only want to render this for isSuccess?
| aria-label={t('Add override')} | ||
| /> | ||
| </ControlItem> | ||
| {isLoading && ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after - the alignment looks maybe a little funky but lets try it out
projects before
grouped projects after
