Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(on-demand): Fix p100 and percentiles #58511

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(on-demand): Fix p100 and percentiles #58511

merged 1 commit into from
Oct 20, 2023

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Oct 20, 2023 •
edited
Loading

This PR fixes the on-demand implementation in the following way:

  • Fixes the percentiles check, which marked valid percentiles as not supported by standard metrics.
  • Removes the query check which is unnecessary.
  • Converts p100 to max for the queries.

@iambriccardo iambriccardo marked this pull request as ready for review October 20, 2023 11:31
@iambriccardo iambriccardo requested a review from a team October 20, 2023 11:31
@iambriccardo iambriccardo requested review from a team as code owners October 20, 2023 11:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 20, 2023
@iambriccardo iambriccardo enabled auto-merge (squash) October 20, 2023 11:54
@iambriccardo iambriccardo merged commit 1aac828 into master Oct 20, 2023
52 checks passed
@iambriccardo iambriccardo deleted the riccardo/fix/p100-fix branch October 20, 2023 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obostjancic obostjancic obostjancic approved these changes

@RaduW RaduW RaduW approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iambriccardo @RaduW @obostjancic