-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(hybridcloud) Remove smtp command from devserver #58361
Conversation
Instead of spending the time to upgrade this to work with multi-region sentry, it is less effort to not have it anymore. We don't run this command in any environment, and it is not part of any commonly used developer workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, is it worth mentioning this in a changelog or something in case any self-hosted users happen to be using it for whatever reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #58361 +/- ##
=======================================
Coverage 79.08% 79.08%
=======================================
Files 5144 5143 -1
Lines 223981 223930 -51
Branches 37714 37706 -8
=======================================
- Hits 177132 177095 -37
+ Misses 41173 41164 -9
+ Partials 5676 5671 -5 |
Instead of spending the time to upgrade this to work with multi-region sentry, it is less effort to not have it anymore. We don't run this command in any environment, and it is not part of any commonly used developer workflow.