-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update release threshold api routes #58177
Conversation
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Codecov Report
@@ Coverage Diff @@
## master #58177 +/- ##
==========================================
+ Coverage 78.39% 79.05% +0.65%
==========================================
Files 5135 5135
Lines 223461 223465 +4
Branches 37624 37626 +2
==========================================
+ Hits 175185 176659 +1474
+ Misses 42629 41150 -1479
- Partials 5647 5656 +9
|
@nhsiehgit can you remind me the object hierarchy here? Makes sense if we fetch the same release threasholds for all releases in an org. If we have different thresholds for each realease something like |
@sentaur-athena Yup - thresholds are per project/env |
rather than conflicting with the existing
/releases/
routesopt to simply have a separate url to manage release thresholds
NOTE: none of these routes are being utilized atm