Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add new option to toggle reading from new cache schema for indexer #58170

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

john-z-yang
Copy link
Member

No description provided.

@john-z-yang john-z-yang marked this pull request as ready for review October 16, 2023 16:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #58170 (80bc1c2) into master (9b312b3) will decrease coverage by 0.01%.
Report is 7 commits behind head on master.
The diff coverage is 6.25%.

@@            Coverage Diff             @@
##           master   #58170      +/-   ##
==========================================
- Coverage   79.05%   79.05%   -0.01%     
==========================================
  Files        5135     5135              
  Lines      223443   223461      +18     
  Branches    37617    37624       +7     
==========================================
+ Hits       176652   176663      +11     
- Misses      41141    41145       +4     
- Partials     5650     5653       +3     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
static/app/components/events/eventAttachments.tsx 81.81% <ø> (ø)
static/app/views/profiling/content.tsx 0.00% <ø> (ø)
src/sentry/snuba/metrics_layer/query.py 58.00% <0.00%> (-7.91%) ⬇️

... and 8 files with indirect coverage changes

@john-z-yang john-z-yang merged commit 485684b into master Oct 16, 2023
51 of 52 checks passed
@john-z-yang john-z-yang deleted the john/update-caching-idxer-schema-read-option branch October 16, 2023 19:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants