Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): adds backfill for weekly report settings #58168

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Oct 16, 2023

Need to backfill the weekly report settings because it comes from a different source than the rest of the notifications

@scefali scefali requested review from snigdhas and a team October 16, 2023 16:45
@scefali scefali requested a review from a team as a code owner October 16, 2023 16:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2023
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0574_backfill_weekly_report_settings.py ()

--
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
--

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #58168 (fa264ee) into master (2f5451f) will increase coverage by 0.48%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

❗ Current head fa264ee differs from pull request most recent head 05f8f95. Consider uploading reports for the commit 05f8f95 to get more accurate results

@@            Coverage Diff             @@
##           master   #58168      +/-   ##
==========================================
+ Coverage   78.57%   79.05%   +0.48%     
==========================================
  Files        5135     5135              
  Lines      223490   223455      -35     
  Branches    37626    37617       -9     
==========================================
+ Hits       175597   176660    +1063     
+ Misses      42200    41145    -1055     
+ Partials     5693     5650      -43     

see 123 files with indirect coverage changes

@scefali scefali merged commit f2145d9 into master Oct 16, 2023
50 checks passed
@scefali scefali deleted the feat/backfill_weekly_report_settings branch October 16, 2023 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants