Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(actionable-items): remove feature flag frontend #57933

Merged
merged 7 commits into from
Oct 16, 2023
Merged

chore(actionable-items): remove feature flag frontend #57933

merged 7 commits into from
Oct 16, 2023

Conversation

roggenkemper
Copy link
Member

@roggenkemper roggenkemper commented Oct 11, 2023 •
edited
Loading

the actionable items alert has been in GA for over a week so we can remove the feature flag and replace the event error with it.

closes #57917

@roggenkemper roggenkemper mentioned this pull request Oct 11, 2023
Merged
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 11, 2023
@roggenkemper roggenkemper marked this pull request as ready for review October 12, 2023 20:16
@roggenkemper roggenkemper requested a review from a team as a code owner October 12, 2023 20:16
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #57933 (ecaa01a) into master (9b312b3) will increase coverage by 0.30%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Current head ecaa01a differs from pull request most recent head 098811b. Consider uploading reports for the commit 098811b to get more accurate results

@@            Coverage Diff             @@
##           master   #57933      +/-   ##
==========================================
+ Coverage   78.72%   79.02%   +0.30%     
==========================================
  Files        5135     5130       -5     
  Lines      223443   223020     -423     
  Branches    37617    37556      -61     
==========================================
+ Hits       175902   176250     +348     
+ Misses      41796    41128     -668     
+ Partials     5745     5642     -103

see 219 files with indirect coverage changes

@roggenkemper roggenkemper enabled auto-merge (squash) October 16, 2023 16:48
@roggenkemper roggenkemper merged commit de3a4e8 into master Oct 16, 2023
53 checks passed
@roggenkemper roggenkemper deleted the roggenkemper/rmaifffe branch October 16, 2023 17:09
roggenkemper added a commit that referenced this pull request Oct 16, 2023
@roggenkemper
chore(actionable-items): remove feature flag backend (#57934)
37022bb 
we have had the actionable items alert in GA for over a week so we can
remove the feature flag.

only merge after #57933 is
merged

closes #57917
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Feature Flag
2 participants
@roggenkemper @scttcper